View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
0001979 | OpenClonk | Objects | public | 2018-01-16 22:03 | 2018-02-15 12:06 | ||||||||
Reporter | Luchs | ||||||||||||
Assigned To | |||||||||||||
Priority | normal | Severity | minor | Reproducibility | always | ||||||||
Status | new | Resolution | open | ||||||||||
Product Version | git master | ||||||||||||
Target Version | 8.1 | Fixed in Version | |||||||||||
Summary | 0001979: Some buildings have badly placed vertices | ||||||||||||
Description | See attached screenshot. | ||||||||||||
Tags | No tags attached. | ||||||||||||
Attached Files |
|
![]() |
|
Clonkonaut (developer) 2018-01-16 22:24 |
What is the exact problem? The straight line of vertices? That buildings sometimes sit on top of the landscape? And what is your proposal? |
Caesar (developer) 2018-01-16 22:38 |
@Clonkonaut: I'm guessing it's that on the roofs, they don't really correspond to where the building ends… (If that's the case I think we could ignore this bug for 8.0.) |
Clonkonaut (developer) 2018-01-16 22:42 |
Ah. I didn't see those up there! |
Luchs (administrator) 2018-01-16 23:25 |
Yeah, it's mostly the roof vertices that don't fit. However, especially the steam engine only has a couple of vertices in the middle and tends to fall through the landscape when digging at the wrong spot. I'm fine with ignoring the other buildings for 8.0. The top vertices usually only matter for building placement anyways, I think? |
Luchs (administrator) 2018-01-19 08:12 |
https://github.com/openclonk/openclonk/commit/9eef4e2a9f6d356d32b930c487162e18db7ae6c2 - probably fixed now? |
Clonkonaut (developer) 2018-01-19 09:30 |
I didn't fix all buildings. I left out those affected by 0001980. So this should stay open as a reminder. |
Zapper (developer) 2018-01-19 16:19 |
@Clonkonaut 0001980 is fixed now. Only the foundry is now flippable and wasn't before. What to do now? |
Clonkonaut (developer) 2018-01-19 17:05 |
@Zapper Make the vertices of the foundry more centralised, ideally symmetrical. Have a critical look if the bottom vertices are sufficient to keep the foundry at its place unless a good deal of earth was dug away. |
occ (reporter) 2018-01-31 19:00 |
Hi! There's been a check-in that references this bug. For more information you can visit the repository browser at this address: https://git.openclonk.org/openclonk.git/commitdiff/9e01a861ce4322df8a63f1dcb84cd49ca76d37b9 Changeset 9e01a86 by Maikel de Vries <mdt.maikel@gmail.com> fix some more structure vertices, also for asymmetric ones when flipped (0001979) |
Maikel (developer) 2018-01-31 19:01 |
Did some more fixes and I think there is only one problem left. Namely the windmill and its wings which do not have the vertices in sync and at the right place. But I don't understand the undocumented code there... |
Clonkonaut (developer) 2018-02-05 11:14 |
I don't think it is that important to have these vertices in sync with the wings. |
Maikel (developer) 2018-02-05 13:03 |
It looks really stupid if the wings are stuck mid-air. But we can postpone this until 9.0 or even later, or a separate report. |
occ (reporter) 2018-02-15 12:06 |
Hi! There's been a check-in that references this bug. For more information you can visit the repository browser at this address: https://git.openclonk.org/openclonk.git/commitdiff/c46b66002c43dc46f1e7dafd116f5836d2f0c787 Changeset c46b660 by Maikel de Vries <mdt.maikel@gmail.com> fix some more structure vertices, also for asymmetric ones when flipped (0001979) |
![]() |
|||
Date Modified | Username | Field | Change |
---|---|---|---|
2018-01-16 22:03 | Luchs | New Issue | |
2018-01-16 22:03 | Luchs | File Added: building vertices.png | |
2018-01-16 22:24 | Clonkonaut | Note Added: 0006073 | |
2018-01-16 22:38 | Caesar | Note Added: 0006074 | |
2018-01-16 22:42 | Clonkonaut | Note Added: 0006075 | |
2018-01-16 23:25 | Luchs | Note Added: 0006078 | |
2018-01-19 08:12 | Luchs | Note Added: 0006080 | |
2018-01-19 09:30 | Clonkonaut | Note Added: 0006081 | |
2018-01-19 16:19 | Zapper | Note Added: 0006084 | |
2018-01-19 17:05 | Clonkonaut | Note Added: 0006085 | |
2018-01-31 09:56 | Caesar | Target Version | 8.0 => 8.1 |
2018-01-31 19:00 | occ | Note Added: 0006109 | |
2018-01-31 19:01 | Maikel | Note Added: 0006110 | |
2018-02-05 11:14 | Clonkonaut | Note Added: 0006113 | |
2018-02-05 13:03 | Maikel | Note Added: 0006114 | |
2018-02-15 12:06 | occ | Note Added: 0006133 |