Anonymous Login
2020-02-24 06:05 UTC

View Issue Details Jump to Notes ]
IDProjectCategoryView StatusLast Update
0001964OpenClonkObjectspublic2017-12-27 14:46
ReporterLuchs 
Assigned ToZapper 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
Product Versiongit master 
Target Version8.0Fixed in Version 
Summary0001964: Partially used loam is sorted inconsistently
DescriptionWhen opening the inventory menu, partially used loam is sorted together with complete loam. Once you take out any item, the partially used loam is sorted to the front. This is very annoying if you're trying to take out multiple items.
TagsNo tags attached.
Attached Files

-Relationships
+Relationships

-Notes

~0005938

Luchs (administrator)

Screenshot124.png - before taking out a wood
Screenshot125.png - after taking out a wood

Note that the cursor is now over metal instead of wood.

~0005981

occ (reporter)

Hi! There's been a check-in that references this bug. For more information you can visit the repository browser at this address:
https://git.openclonk.org/openclonk.git/commitdiff/d108cdd6aa527b54be36fcff0488c390eb78b0ce

Changeset d108cdd by David Dormagen <czapper@gmx.de>
inventory menu: be more lenient when it comes to finding matches between updates (0001964)

The matching had a few issues:
Items with the same symbol were supposed to be stacked, but the "symbol" changed from ID to object at some point. So same-type objects were no longer correctly matched.
Items with different text (e.g. amount) but everything else the same should be stacked. But simple proplist equality is obviously not sufficient to determine whether the contents of the proplist changed.

The order of the items is generally more stable now. I hope this doesn't introduce other issues.

~0005982

Zapper (developer)

I generally made the matching more lenient.

Not 100% sure about what the problem for the loam was, but objects with amounts were not matched at all. And now also the loam works in my tests.
+Notes

-Issue History
Date Modified Username Field Change
2017-12-17 22:06 Luchs New Issue
2017-12-17 22:06 Luchs File Added: Screenshot124.png
2017-12-17 22:07 Luchs File Added: Screenshot125.png
2017-12-17 22:08 Luchs Note Added: 0005938
2017-12-27 14:44 occ Note Added: 0005981
2017-12-27 14:46 Zapper Assigned To => Zapper
2017-12-27 14:46 Zapper Status new => resolved
2017-12-27 14:46 Zapper Resolution open => fixed
2017-12-27 14:46 Zapper Note Added: 0005982
+Issue History