View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
---|---|---|---|---|---|---|---|---|---|
0001928 | OpenClonk | Engine | public | 2017-06-30 08:19 | 2017-08-14 13:08 | ||||
Reporter | pkern | ||||||||
Assigned To | |||||||||
Priority | normal | Severity | minor | Reproducibility | have not tried | ||||
Status | resolved | Resolution | fixed | ||||||
Product Version | |||||||||
Target Version | 8.0 | Fixed in Version | 8.0 | ||||||
Summary | 0001928: Apply patch for reproducible builds | ||||||||
Description | In https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=823797 I received a patch from Alexis Bienvenüe <pado@passoire.fr> (as attached) to fix the build system to produce a reproducible (bit identical) build on Debian. This requires looking at SOURCE_DATE_EPOCH if set in the environment instead of date to get the current year at build (which is displayed in a copyright notice). I'd be nice if this could be included in the next release of OpenClonk. | ||||||||
Tags | No tags attached. | ||||||||
Attached Files |
|
![]() |
|
Caesar (developer) 2017-08-13 09:45 |
We're now using STRING(TIMESTAMP C4COPYRIGHT_YEAR "%Y") (see https://git.openclonk.org/openclonk.git/commitdiff/8fef67378d193e7d116c61b4b359a8788388d6fa ) and I was wondering if this patch is still necessary. |
Luchs (administrator) 2017-08-13 10:38 |
cmake >= 3.8 seems to honor SOURCE_DATE_EPOCH [1], so it's probably fine as-is. [1]: https://cmake.org/cmake/help/latest/command/string.html#timestamp |
![]() |
|||
Date Modified | Username | Field | Change |
---|---|---|---|
2017-06-30 08:19 | pkern | New Issue | |
2017-06-30 08:19 | pkern | File Added: openclonk_7.0-3_reproductible.diff | |
2017-08-05 13:58 | Maikel | Target Version | => 8.0 |
2017-08-13 09:44 | Caesar | Note Added: 0005721 | |
2017-08-13 09:45 | Caesar | Note Deleted: 0005721 | |
2017-08-13 09:45 | Caesar | Assigned To | => Caesar |
2017-08-13 09:45 | Caesar | Status | new => feedback |
2017-08-13 09:45 | Caesar | Note Added: 0005722 | |
2017-08-13 10:38 | Luchs | Note Added: 0005723 | |
2017-08-14 13:08 | Caesar | Assigned To | Caesar => |
2017-08-14 13:08 | Caesar | Status | feedback => resolved |
2017-08-14 13:08 | Caesar | Resolution | open => fixed |
2017-08-14 13:08 | Caesar | Fixed in Version | => 8.0 |