|View Issue Details|
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0001779||OpenClonk||Engine - GUI||public||2016-07-07 13:59||2017-08-20 12:02|
|Target Version||9.0||Fixed in Version|
|Summary||0001779: "Pings" tab in /chart is empty|
|Description||The ping tab in /chart is broken again because of https://git.openclonk.org/openclonk.git/blobdiff/58aec33841fdd4a7656530fad57a1fd558bc8dc6..3c625a00dd46e544a738f40eaab6d0cb083f8e68:/src/network/C4Network2Stats.cpp|
C4Game::Init creates the C4Network2Stats instance and assigns it to pNetworkStatistics: https://git.openclonk.org/openclonk.git/blob/HEAD:/src/game/C4Game.cpp#l496
The constructor of C4Network2Stats calls C4Network2Client::CreateGraphs for each client: https://git.openclonk.org/openclonk.git/blob/HEAD:/src/network/C4Network2Stats.cpp#l322
However, C4Network2Client::CreateGraphs cannot add the graph if pNetworkStatistics is not assigned: https://git.openclonk.org/openclonk.git/blob/HEAD:/src/network/C4Network2Client.cpp#l328
|Tags||No tags attached.|
I should explain why I submitted a bug report instead of a patch that simply undoes the change to C4Network2Stats.cpp.
First, calling methods of C4Network2Stats while the instance is still being constructed is probably not a good idea. So maybe adding the ping graph for a client should be deferred, also because ping graphs are currently only added for the clients that were present when the local client joined. If another client joins via runtime join, there is no ping graph for him.
|2016-07-07 13:59||Jan||New Issue|
|2016-07-07 14:30||Jan||Note Added: 0005185|
|2017-08-05 13:58||Maikel||Target Version||=> 8.0|
|2017-08-20 12:02||Zapper||Target Version||8.0 => 9.0|