| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 0001732 | OpenClonk | Engine - Controls | public | 2016-05-01 15:23 | 2017-08-20 11:48 | ||||||||
| Reporter | Zapper | ||||||||||||
| Assigned To | |||||||||||||
| Priority | normal | Severity | minor | Reproducibility | N/A | ||||||||
| Status | new | Resolution | open | ||||||||||
| Product Version | |||||||||||||
| Target Version | 9.0 | Fixed in Version | |||||||||||
| Summary | 0001732: remove spec_id argument from PlayerControl | ||||||||||||
| Description | The argument is used to forward a call to a definition. Instead, the engine should make the definition call itself. That would remove some overhead. One the same note, the callback ForwardedPlayerControl should then be renamed PlayerControl. But hey, we are not even using that one anyway. | ||||||||||||
| Additional Information | related: https://git.openclonk.org/openclonk.git/commit/f4ae76454bc1ee60747d26b2548b200e32b98593 required changes: <Guenther> instead of ::ScriptEngine.GetPropList()->Call(PSF_PlayerControl, &Pars).getBool(); <Guenther> (C4Id2Def(idControlExtraData) ? C4Id2Def(idControlExtraData) : ::ScriptEngine.GetPropList())->Call(PSF_PlayerControl, &Pars).getBool(); | ||||||||||||
| Tags | No tags attached. | ||||||||||||
| Attached Files |
| ||||||||||||
 Relationships |
|
 Relationships |
| Notes |
|
| There are no notes attached to this issue. |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2016-05-01 15:23 | Zapper | New Issue | |
| 2017-08-20 11:48 | Zapper | Target Version | 8.0 => 9.0 |
| Issue History |
