Anonymous Login
2018-12-16 10:45 UTC

View Issue Details Jump to Notes ]
IDProjectCategoryView StatusLast Update
0001732OpenClonkEngine - Controlspublic2017-08-20 11:48
ReporterZapper 
Assigned To 
PrioritynormalSeverityminorReproducibilityN/A
StatusnewResolutionopen 
Product Version 
Target Version9.0Fixed in Version 
Summary0001732: remove spec_id argument from PlayerControl
DescriptionThe argument is used to forward a call to a definition. Instead, the engine should make the definition call itself.

That would remove some overhead.

One the same note, the callback ForwardedPlayerControl should then be renamed PlayerControl. But hey, we are not even using that one anyway.
Additional Informationrelated:
https://git.openclonk.org/openclonk.git/commit/f4ae76454bc1ee60747d26b2548b200e32b98593

required changes:
<Guenther> instead of ::ScriptEngine.GetPropList()->Call(PSF_PlayerControl, &Pars).getBool();
<Guenther> (C4Id2Def(idControlExtraData) ? C4Id2Def(idControlExtraData) : ::ScriptEngine.GetPropList())->Call(PSF_PlayerControl, &Pars).getBool();
TagsNo tags attached.
Attached Files

-Relationships
+Relationships

-Notes
There are no notes attached to this issue.
+Notes

-Issue History
Date Modified Username Field Change
2016-05-01 15:23 Zapper New Issue
2017-08-20 11:48 Zapper Target Version 8.0 => 9.0
+Issue History