View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
0001642 | OpenClonk | Website - Automated Builds | public | 2016-01-19 16:33 | 2017-10-26 13:02 | ||||||||
Reporter | Luchs | ||||||||||||
Assigned To | |||||||||||||
Priority | normal | Severity | minor | Reproducibility | always | ||||||||
Status | new | Resolution | open | ||||||||||
Product Version | |||||||||||||
Target Version | git master | Fixed in Version | |||||||||||
Summary | 0001642: In the release source tarball, all files are marked as executable | ||||||||||||
Description | Only files that are actually executable should be marked as executable. | ||||||||||||
Steps To Reproduce | wget http://www.openclonk.org/builds/release/7.0/openclonk-7.0-src.tar.bz2 tar tvf openclonk-7.0-src.tar.bz2 | ||||||||||||
Additional Information | http://www.openclonk.org/builds/release/7.0/openclonk-7.0-src.tar.bz2 | ||||||||||||
Tags | No tags attached. | ||||||||||||
Attached Files |
|
![]() |
|
Isilkor (developer) 2016-01-19 21:08 |
Not my bug, the exported source tree (https://git.openclonk.org/openclonk.git/archive/openclonk-release-7.0-src.tar.bz2) is correct; somebody broke things when uploading to www.openclonk.org |
Isilkor (developer) 2016-01-23 19:43 |
Reminder sent to: Newton Newton may have uploaded the tarball to openclonk.org. |
Newton (administrator) 2016-01-24 10:56 |
Apparently Windows does add it when I touch the contents of the tar. I do unpack and pack it again because I remove the Experimental.ocf, Tests.ocf etc. folders as I do not want them to turn up in * Linux packages of the game (.deb, .rpm,...) * the folder in which a (Linux) user decides to compile the game himself That I do this manually is a temporary solution anyway. Couldn't the build system be extended to do this automatically? When is the source package on git archive created - is it already available when the release button is pushed? |
Isilkor (developer) 2016-01-24 10:57 |
> When is the source package on git archive created - is it already available when the release button is pushed? It's created whenever somebody pushes a tag to the repository. |
Newton (administrator) 2016-01-24 11:15 |
...Which happens after the button has been pushed. So the release scripts have to create a source tar themself. |
Isilkor (developer) 2016-01-24 11:22 |
> Which happens after the button has been pushed. Well if somebody releases before pushing a tag that's their own fault. |
Newton (administrator) 2016-01-24 12:02 |
That is beside the point, it is enough that it is possible and valid to do so (as it is described like this in the wiki) that makes it necessary that the release scripts have to create a source tar themselves. |
Isilkor (developer) 2016-01-24 12:14 Last edited: 2016-01-24 12:14 |
Ignoring the wiki, since you won't find anything there because there's no search function, let me quote the release tool for you: Pre Release Checklist Dont forget to increase the version number in Version.txt. Run a Dry Release to make sure the generated files are correct. Dry Release Area Create a tag for the release. Emphasis mine. |
Newton (administrator) 2016-01-24 13:36 Last edited: 2016-01-24 13:37 |
My previous point holds. Anyway, the wiki article is here: http://wiki.openclonk.org/w/Release_Steps I corrected it. |
Maikel (developer) 2016-01-24 13:48 |
In the 6.0 series we explicitly decided to tag after the release has been done, in case something goes wrong. So now we change that? |
Isilkor (developer) 2016-01-24 13:53 |
"In case something goes wrong" doesn't really apply because we can do dry releases, which do the exact same thing as the real deal except updating the website. |
![]() |
|||
Date Modified | Username | Field | Change |
---|---|---|---|
2016-01-19 16:33 | Luchs | New Issue | |
2016-01-19 16:33 | Luchs | Status | new => assigned |
2016-01-19 16:33 | Luchs | Assigned To | => Isilkor |
2016-01-19 21:08 | Isilkor | Note Added: 0004827 | |
2016-01-19 21:08 | Isilkor | Assigned To | Isilkor => |
2016-01-19 21:08 | Isilkor | Status | assigned => new |
2016-01-23 19:43 | Isilkor | Note Added: 0004858 | |
2016-01-24 10:56 | Newton | Note Added: 0004862 | |
2016-01-24 10:57 | Isilkor | Note Added: 0004863 | |
2016-01-24 11:15 | Newton | Note Added: 0004864 | |
2016-01-24 11:22 | Isilkor | Note Added: 0004865 | |
2016-01-24 12:02 | Newton | Note Added: 0004867 | |
2016-01-24 12:14 | Isilkor | Note Added: 0004868 | |
2016-01-24 12:14 | Isilkor | Note Edited: 0004868 | View Revisions |
2016-01-24 13:36 | Newton | Note Added: 0004869 | |
2016-01-24 13:37 | Newton | Note Edited: 0004869 | View Revisions |
2016-01-24 13:48 | Maikel | Note Added: 0004870 | |
2016-01-24 13:53 | Isilkor | Note Added: 0004871 | |
2017-08-05 13:58 | Maikel | Target Version | => 8.0 |
2017-10-26 13:02 | Clonkonaut | Target Version | 8.0 => git master |