| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 0001430 | OpenClonk | Engine - GUI | public | 2015-10-19 08:45 | 2017-08-12 20:40 | ||||||||
| Reporter | Zapper | ||||||||||||
| Assigned To | |||||||||||||
| Priority | low | Severity | minor | Reproducibility | N/A | ||||||||
| Status | confirmed | Resolution | open | ||||||||||
| Product Version | |||||||||||||
| Target Version | 9.0 | Fixed in Version | |||||||||||
| Summary | 0001430: Disallow creating a script GUI window from an object instead of a proplist | ||||||||||||
| Description | Currently it is possible to create an UI window from an object (because objects are also just proplists) and this is also well-used in the MenuStyle_ definitions. While helpful in some cases (which was the reason for allowing it), it might be very error prone: Objects may contain all global definitions (i.e. static variables) and all functions as properties. Thus it is probably possible that an extension package or scenario that defines some special static variable can break existing UIs or lead to extremely weird behavior. Also, see related bug: it is easier to introduce other strange behavior when using objects as UI items (because the objects can contain local variables that point to other objects, etc.). This will also speed up UI creation which now uses objects, because less properties will need to be checked. | ||||||||||||
| Tags | No tags attached. | ||||||||||||
| Attached Files |
| ||||||||||||
 Relationships |
 Notes |
|
|
Zapper (developer) 2015-12-25 22:40 |
As this has no impact on actual gameplay and players can't notice it (it is just a little error-prone/slower from a developer's point of view), I'll target it to 8.0, because it needs some script changes that could potentially break some things. |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2015-10-19 08:45 | Zapper | New Issue | |
| 2015-10-19 08:45 | Zapper | Relationship added | parent of 0001420 |
| 2015-10-26 13:14 | Clonkonaut | Status | new => confirmed |
| 2015-12-25 22:40 | Zapper | Note Added: 0004390 | |
| 2015-12-25 22:40 | Zapper | Target Version | 7.0 => 8.0 |
| 2017-08-12 20:40 | Zapper | Target Version | 8.0 => 9.0 |
| Issue History |
