| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 0001429 | OpenClonk | Engine - Graphics | public | 2015-10-18 21:17 | 2017-12-23 11:35 | ||||||||
| Reporter | Clonk-Karl | ||||||||||||
| Assigned To | |||||||||||||
| Priority | normal | Severity | minor | Reproducibility | always | ||||||||
| Status | acknowledged | Resolution | open | ||||||||||
| Platform | Linux | OS | Gentoo Linux | OS Version | ~amd64 | ||||||||
| Product Version | |||||||||||||
| Target Version | git master | Fixed in Version | |||||||||||
| Summary | 0001429: Landscape edges have shadows | ||||||||||||
| Description | This comes from landscape edges being marked as material borders. They shouldn't at least when the sides are not open. See screenshot. | ||||||||||||
| Steps To Reproduce | Start Tests.ocf/Minimal.ocs, walk to the left or right edge of the landscape. | ||||||||||||
| Tags | No tags attached. | ||||||||||||
| Attached Files |
| ||||||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
Sven2 (developer) 2015-10-18 22:16 |
I don't think this is a problem. The border is "magical" anyway, why shouldn't it drop a shadow? |
|
Clonk-Karl (administrator) 2015-10-18 23:01 |
To me it looks unnatural somehow. Like there's a 90 degree cliff right where the landscape ends. Maybe the clonk world is a disk :P By the way, on the other side of the map the edge is actually brighter, not darker than the rest of the material. Like there's an extra light source somewhere on that side of the landscape. |
|
Sven2 (developer) 2015-10-18 23:03 Last edited: 2015-10-18 23:04 |
Well, but is there a way to solve it without having a ton of coordinate border checks in the shader code? Like a texture addressing mode that mirrors the borders (but would that work with non-POT?) |
|
Clonk-Karl (administrator) 2015-10-18 23:28 |
The material edges are computed in CPU. And it makes sense that way, because if they were in the shader, they would need lots of texture fetches for each fragment. I'd expect a fix for this to be fairly simple actually. |
|
Clonkonaut (developer) 2015-11-30 11:16 |
Changed Target Version to 8.0 This isn't release blocking and even if the fix is easy, no one's done it yet! But can be done anytime. |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2015-10-18 21:17 | Clonk-Karl | New Issue | |
| 2015-10-18 21:17 | Clonk-Karl | Target Version | => 7.0 |
| 2015-10-18 21:17 | Clonk-Karl | File Added: shadow_at_border.png | |
| 2015-10-18 22:16 | Sven2 | Note Added: 0003969 | |
| 2015-10-18 23:01 | Clonk-Karl | Note Added: 0003971 | |
| 2015-10-18 23:03 | Sven2 | Note Added: 0003972 | |
| 2015-10-18 23:04 | Sven2 | Note Edited: 0003972 | View Revisions |
| 2015-10-18 23:28 | Clonk-Karl | Note Added: 0003973 | |
| 2015-11-30 11:16 | Clonkonaut | Status | new => acknowledged |
| 2015-11-30 11:16 | Clonkonaut | Target Version | 7.0 => 8.0 |
| 2015-11-30 11:16 | Clonkonaut | Note Added: 0004169 | |
| 2017-12-23 11:35 | Luchs | Target Version | 8.0 => git master |
| Issue History |
