| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 0001428 | OpenClonk | Engine | public | 2015-10-16 12:08 | 2019-05-06 19:25 | ||||||||
| Reporter | Clonkonaut | ||||||||||||
| Assigned To | Clonk-Karl | ||||||||||||
| Priority | low | Severity | crash | Reproducibility | always | ||||||||
| Status | assigned | Resolution | open | ||||||||||
| Platform | PC | OS | Windows | OS Version | 8.1 | ||||||||
| Product Version | |||||||||||||
| Target Version | git master | Fixed in Version | |||||||||||
| Summary | 0001428: Definition reloading crashes often | ||||||||||||
| Description | Depending on what you change, the engine crashes when reloading a definition. If objects with meshes are reloaded, they often turn white. I will continue to collect examples of action that do crash the engine. So far: Changing vertices Changing .material | ||||||||||||
| Tags | No tags attached. | ||||||||||||
| Attached Files |
| ||||||||||||
 Relationships |
||||||
|
||||||
 Relationships |
| Notes |
|
|
Sven2 (developer) 2015-10-16 15:39 |
I might be mistaken, but I think any change in a definition just causes a definition reload. And then the crash usually happens due to the script engine re-compilation causing dead pointers somewhere. |
|
Clonk-Karl (administrator) 2015-10-17 23:05 |
I fixed a problem with reloading mesh materials. Cannot reproduce a crash when changing vertices, though. On which scenario does this happen, and when changing the vertices of which object? |
|
Clonkonaut (developer) 2015-10-18 12:28 Last edited: 2015-10-19 07:50 |
You're right, just changing the vertex doesn't crash. After having changed it, you need to select it with the edit cursor and try to move it. /e That may be the case with more crashes on definition reloading. |
|
Clonk-Karl (administrator) 2015-10-18 22:56 |
I don't even need to change anything in the DefCore.txt for this to crash. Crashes somewhere deep down in the mysteries of C4PropList. I think the definition proplist gets recreated but the object proplist still accesses some parts of the old definition proplist, e.g. Action points into the old ActMap. |
|
Clonkonaut (developer) 2015-10-19 07:50 |
Yes, it doesn't seem linked to any change in particular and may very well be the reason why I thought that various things crashed the engine. |
|
Foaly (developer) 2019-05-06 07:42 |
I've traced one crash back to Objects.ocd/HUD.ocd/ControllerLibrary.ocd/Script.c:76 in OnSynchronized() It schedules a call to Reset which in turn calls Construction, where it then crashes. Either Construction itself, or a function within it appears to have been freed during UnLink. |
|
Foaly (developer) 2019-05-06 19:25 |
I am speculating that ScheduleCall saves a reference to the old GUI_Controller.Reset. However, this does not crash yet, because it does correct reference counting. But then the call to Construction fails, because the other function of GUI_Controller don't exist anymore. Also a strange thing: Changing the following line in GUI_Controller.Reset from Construction(); to this->Construction(); makes it not crash anymore. I assume this is because a call via "this" is looked up, but for a regular call, the function reference is embedded into the bytecode. |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2015-10-16 12:08 | Clonkonaut | New Issue | |
| 2015-10-16 15:39 | Sven2 | Note Added: 0003947 | |
| 2015-10-17 23:05 | Clonk-Karl | Note Added: 0003958 | |
| 2015-10-17 23:05 | Clonk-Karl | Assigned To | => Clonk-Karl |
| 2015-10-17 23:05 | Clonk-Karl | Status | new => feedback |
| 2015-10-18 12:28 | Clonkonaut | Note Added: 0003964 | |
| 2015-10-18 12:28 | Clonkonaut | Status | feedback => assigned |
| 2015-10-18 12:29 | Clonkonaut | Note Edited: 0003964 | View Revisions |
| 2015-10-18 22:56 | Clonk-Karl | Note Added: 0003970 | |
| 2015-10-19 07:50 | Clonkonaut | Note Edited: 0003964 | View Revisions |
| 2015-10-19 07:50 | Clonkonaut | Note Added: 0003974 | |
| 2016-01-31 05:46 | Clonk-Karl | Relationship added | related to 0001658 |
| 2017-08-05 13:58 | Maikel | Target Version | => 8.0 |
| 2017-08-20 11:30 | Zapper | Target Version | 8.0 => 8.1 |
| 2017-10-26 13:23 | Clonkonaut | Target Version | 8.1 => git master |
| 2019-05-06 07:42 | Foaly | Note Added: 0006258 | |
| 2019-05-06 19:25 | Foaly | Note Added: 0006259 | |
| Issue History |
