Anonymous Login
2018-06-25 09:51 UTC

View Issue Details Jump to Notes ]
IDProjectCategoryView StatusLast Update
0001179OpenClonkEngine - GUIpublic2018-01-09 16:12
ReporterMaikel 
Assigned To 
PrioritynormalSeverityfeatureReproducibilityN/A
StatusnewResolutionopen 
Product Version 
Target Version8.1Fixed in Version 
Summary0001179: Show message about playing tutorials
DescriptionIt would be good to point the new players of the game to the tutorials via a message on game start up. The message should always come unless the player ticks a box to remove the showing on start up.

Best case would be another button in the message which points the player directly to the tutorials.
TagsNo tags attached.
Attached Files
  • patch file icon 0001-Blargh.patch (4,260 bytes) 2017-12-19 15:58 -
    From 5e486d781cc7b7db1020b728b0966b6eed3bbc36 Mon Sep 17 00:00:00 2001
    From: Julius Michaelis <gitter@liftm.de>
    Date: Tue, 19 Dec 2017 16:55:28 +0100
    Subject: [PATCH] Blargh
    
    ---
     planet/System.ocg/LanguageDE.txt |  2 ++
     planet/System.ocg/LanguageUS.txt |  2 ++
     src/gui/C4StartupPlrSelDlg.cpp   | 11 +++++++++++
     src/network/C4Network2IO.cpp     |  4 +---
     4 files changed, 16 insertions(+), 3 deletions(-)
    
    diff --git a/planet/System.ocg/LanguageDE.txt b/planet/System.ocg/LanguageDE.txt
    index 5781f87aa..751b4e2de 100644
    --- a/planet/System.ocg/LanguageDE.txt
    +++ b/planet/System.ocg/LanguageDE.txt
    @@ -665,6 +665,8 @@ IDS_MSG_LOOKINGFORUPDATES=Suche nach Updates...
     IDS_MSG_MAP_DESC=Szenario auf der Karte wählen.
     IDS_MSG_MAP_STARTSCEN=Szenario %s starten
     IDS_MSG_MMTIMER_DESC=Kann bei Problemen mit der Spielgeschwindigkeit helfen.
    +IDS_MSG_NEWPLAYERSUGGESTTUTORIAL=Du hast soeben einen Spieler erstellt.|Möchtest du mit den Lernrunden beginnen?
    +IDS_MSG_NEWPLAYERSUGGESTTUTORIAL_TITLE=Neuer Spieler - Neues Training
     IDS_MSG_NEWPLRCOLOR=Neue &Farbe
     IDS_MSG_NEWPLRCOLOR_DESC=Zufällige neue Farbe aussuchen
     IDS_MSG_NEWRELEASEAVAILABLE=Für die neue Version ist kein Update-Paket verfügbar. Bitte lade die neue Version von der Download-Seite herunter.
    diff --git a/planet/System.ocg/LanguageUS.txt b/planet/System.ocg/LanguageUS.txt
    index 289d53b05..88caa6662 100644
    --- a/planet/System.ocg/LanguageUS.txt
    +++ b/planet/System.ocg/LanguageUS.txt
    @@ -665,6 +665,8 @@ IDS_MSG_LOOKINGFORUPDATES=Looking for updates...
     IDS_MSG_MAP_DESC=Select scenario from the map.
     IDS_MSG_MAP_STARTSCEN=Start scenario %s
     IDS_MSG_MMTIMER_DESC=Try this option if you experience timing problems during the game, e.g. very slow game even in small scenarios on decent hardware.
    +IDS_MSG_NEWPLAYERSUGGESTTUTORIAL=You just created a player.|Do you want to try the tutorials?
    +IDS_MSG_NEWPLAYERSUGGESTTUTORIAL_TITLE=New player - new training
     IDS_MSG_NEWPLRCOLOR=New &color
     IDS_MSG_NEWPLRCOLOR_DESC=Generate a new random player color
     IDS_MSG_NEWRELEASEAVAILABLE=For the new version there is no update package available. Please download and install the new version from the downloads page.
    diff --git a/src/gui/C4StartupPlrSelDlg.cpp b/src/gui/C4StartupPlrSelDlg.cpp
    index 6e30de74b..830e36fb4 100644
    --- a/src/gui/C4StartupPlrSelDlg.cpp
    +++ b/src/gui/C4StartupPlrSelDlg.cpp
    @@ -19,6 +19,7 @@
     #include "C4Include.h"
     #include "gui/C4StartupPlrSelDlg.h"
     
    +#include "game/C4Application.h"
     #include "graphics/C4Draw.h"
     #include "graphics/C4GraphicsResource.h"
     #include "gui/C4FileSelDlg.h"
    @@ -1604,6 +1605,16 @@ void C4StartupPlrPropertiesDlg::OnClosed(bool fOK)
     						// no main player selection dialog: This means that this dlg was shown as a creation dialog from the main startup dlg
     						// Just set the newly created player as current selection
     						SCopy(Config.AtRelativePath(Filename.getData()), Config.General.Participants, sizeof Config.General.Participants);
    +
    +						// Suggest starting the tutorials
    +						StdStrBuf sMsg; sMsg.Ref(LoadResStr("IDS_MSG_NEWPLAYERSUGGESTTUTORIAL"));
    +						bool start_tutorial = GetScreen()->ShowMessageModal(sMsg.getData(), LoadResStr("IDS_MSG_NEWPLAYERSUGGESTTUTORIAL_TITLE"), C4GUI::MessageDialog::btnYesNo, C4GUI::Ico_AddPlr, nullptr);
    +						if (start_tutorial) {
    +							//C4Startup::Get()->SwitchDialog(C4Startup::SDID_ScenSel);
    +							Application.OpenGame("Tutorials.ocf/Tutorial01.ocs");
    +							//Game.SetScenarioFilename("Tutorials.ocf/Tutorial01.ocs");
    +						}
    +
     					}
     				}
     			}
    diff --git a/src/network/C4Network2IO.cpp b/src/network/C4Network2IO.cpp
    index 7c293a7e5..32f150f35 100644
    --- a/src/network/C4Network2IO.cpp
    +++ b/src/network/C4Network2IO.cpp
    @@ -582,10 +582,8 @@ void C4Network2IO::OnDisconn(const C4NetIO::addr_t &addr, C4NetIO *pNetIO, const
     
     void C4Network2IO::OnPacket(const class C4NetIOPacket &rPacket, C4NetIO *pNetIO)
     {
    -#if C4NET2IO_DUMP_LEVEL > 0
    -	auto tTime = C4TimeMilliseconds::Now();
    -#endif
     #if(C4NET2IO_DUMP_LEVEL > 1)
    +	auto tTime = C4TimeMilliseconds::Now();
     	Application.InteractiveThread.ThreadLogS("OnPacket: %s status %02x %s",
     	           C4TimeMilliseconds::Now().AsString().getData(),
     	           rPacket.getStatus(), getNetIOName(pNetIO));
    -- 
    2.15.0
    
    
    patch file icon 0001-Blargh.patch (4,260 bytes) 2017-12-19 15:58 +

-Relationships
+Relationships

-Notes

~0004338

Sven2 (developer)

I agree, good idea

~0005940

Caesar (developer)

I thought this shouldn't be too hard, but I'm getting some nice Heisenbugs when taking a straight approach to this. Patch attached.

~0006025

Caesar (developer)

Moved to 8.1 as it is non-essential for a release.
+Notes

-Issue History
Date Modified Username Field Change
2014-11-24 09:48 Maikel New Issue
2015-12-17 10:56 Maikel Target Version 6.1 => 7.0
2015-12-18 01:56 Sven2 Note Added: 0004338
2016-01-12 21:21 Clonkonaut Target Version 7.0 => 7.1 (Bugfix update)
2017-08-05 09:04 Maikel Target Version 7.1 (Bugfix update) => 8.0
2017-12-19 15:58 Caesar File Added: 0001-Blargh.patch
2017-12-19 15:58 Caesar Note Added: 0005940
2018-01-09 16:12 Caesar Target Version 8.0 => 8.1
2018-01-09 16:12 Caesar Note Added: 0006025
+Issue History