OpenClonk Bugtracker - OpenClonk
View Issue Details
0002069OpenClonkWebsite - Automated Buildspublic2019-07-24 19:242020-09-12 07:10
ReporterIsilkor 
Assigned ToCaesar 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
Summary0002069: Snapshot does not contain COPYING or TRADEMARK
DescriptionThe snapshots do not contain either COPYING or TRADEMARK files, in violation of the ISC and Clonk trademark licenses.
TagsNo tags attached.
Attached Files

Notes
(0006261)
Luchs   
2019-07-30 18:25   
Can we add this to the About page in the game (probably as a button that opens a text window)? For the Linux snapshot, the user never sees any archive contents, so just including the files would not be very valuable.
(0006263)
Caesar   
2020-05-01 02:36   
Isilkor: whatcha think of https://github.com/jcaesar/openclonk/commit/965ee78dbc367873090c64041fd2c5ef0ec71383 ?
(I'm a bit unhappy that I have to duplicate the license files, but compiling them into the executable itself seems like too much of a cross platform nuisance. Advice appreciated.)
(0006264)
Foaly   
2020-05-03 16:56   
In order to pack a file into the executable, all projects I know generate source code that contains the file as a byte array.
That shouldn't be hard, since we already have CMake.
(0006265)
Caesar   
2020-05-04 11:21   
(Last edited: 2020-05-04 11:22)
I hadn't thought of that. But hm. Do those projects also add an extra executable that is just there to generate the new source file because platform independence is still tricky?

https://github.com/jcaesar/openclonk/commit/c50845199ccbeeb4d2f4532236f3825265285a3c

Or do they somehow hack the generation to be part of the cmake execution? (I suppose you can do it with file(READ/WRITE) plus some magic variables to make CMake recognize those files as "triggers build system rerun". But oh do I hate writing CMake code.)

(0006266)
Foaly   
2020-05-04 13:36   
Blender does it like this: https://github.com/blender/blender/blob/master/source/blender/datatoc/datatoc.c

So yeah, pretty similar, though they encode everything as an array of numbers, because they also use it for binary files.
(0006267)
Caesar   
2020-05-05 03:56   
Meh. Could have just ported that over from LegacyClonk… https://github.com/legacyclonk/LegacyClonk/blob/master/CMakeLists.txt#L118 (It lacks the content license, but I'm not sure that is necessary anyway…)

I'll leave the choice to someone else. https://github.com/openclonk/openclonk/pull/141
(0006269)
Caesar   
2020-05-05 12:27   
I can't believe I now wasted more than a day on this… Isilkor, do we also need the licenses in licenses/ or thirdparty/?
(0006270)
Caesar   
2020-09-12 07:10   
Fix merged

Issue History
2019-07-24 19:24IsilkorNew Issue
2019-07-30 18:25LuchsNote Added: 0006261
2020-05-01 02:36CaesarNote Added: 0006263
2020-05-03 16:56FoalyNote Added: 0006264
2020-05-04 11:21CaesarNote Added: 0006265
2020-05-04 11:21CaesarNote Edited: 0006265bug_revision_view_page.php?bugnote_id=6265#r1395
2020-05-04 11:22CaesarNote Edited: 0006265bug_revision_view_page.php?bugnote_id=6265#r1396
2020-05-04 13:36FoalyNote Added: 0006266
2020-05-05 03:56CaesarNote Added: 0006267
2020-05-05 12:27CaesarNote Added: 0006269
2020-09-12 07:10CaesarAssigned To => Caesar
2020-09-12 07:10CaesarStatusnew => closed
2020-09-12 07:10CaesarResolutionopen => fixed
2020-09-12 07:10CaesarNote Added: 0006270