OpenClonk Bugtracker - OpenClonk
View Issue Details
0001999OpenClonkEnginepublic2018-02-13 19:072019-01-27 21:37
ReporterLuchs 
Assigned ToLuchs 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version8.0 
Target Version9.0Fixed in Version8.1 
Summary0001999: Editor button only works on Windows/Linux
DescriptionThe code currently tries launching /proc/self/exe on non-Windows, but this works on Linux only.

 - On FreeBSD, we'd need to launch /proc/curproc/file.
 - On macOS, we'd probably need to call _NSGetExecutablePath().

We should probably add a dialog that instructs players to launch "openclonk --editor" on unknown systems as well.
TagsNo tags attached.
Attached Files

Notes
(0006140)
occ   
2018-02-17 11:59   
Hi! There's been a check-in that references this bug. For more information you can visit the repository browser at this address:
https://git.openclonk.org/openclonk.git/commitdiff/9855f9355ed97df8af5e0fd1a87ede6f1eaa257e

Changeset 9855f93 by Lukas Werling <lukas.werling@gmail.com>
Autodetect "/proc/self/exe"-equivalent on FreeBSD (0001999)

(0006141)
occ   
2018-02-17 11:59   
Hi! There's been a check-in that references this bug. For more information you can visit the repository browser at this address:
https://git.openclonk.org/openclonk.git/commitdiff/55a81ea76a6908fa4c8fb4511b639b2c8c3a808f

Changeset 55a81ea by Lukas Werling <lukas.werling@gmail.com>
Launch editor via argv[0] on Unix systems without /proc/self/exe (0001999)

(0006143)
Luchs   
2018-02-17 12:03   
The first commit fixes it on FreeBSD. I also added a fallback in the second commit which may work for macOS, but I can't test that.

In any case, something using the proper macOS API may be nice.
(0006147)
occ   
2018-02-18 21:40   
Hi! There's been a check-in that references this bug. For more information you can visit the repository browser at this address:
https://git.openclonk.org/openclonk.git/commitdiff/a09187454684e6a510d0cbefe6a79f74f539bca5

Changeset a091874 by Lukas Werling <lukas.werling@gmail.com>
Autodetect "/proc/self/exe"-equivalent on FreeBSD (0001999)

(0006148)
occ   
2018-02-18 21:40   
Hi! There's been a check-in that references this bug. For more information you can visit the repository browser at this address:
https://git.openclonk.org/openclonk.git/commitdiff/e10d4b3bf513ef57871fb9485c6be5b7c3faf5b5

Changeset e10d4b3 by Lukas Werling <lukas.werling@gmail.com>
Launch editor via argv[0] on Unix systems without /proc/self/exe (0001999)

(0006202)
Luchs   
2019-01-27 21:37   
Well, the release has been out for a while without further complaints, so it might be fine.

Issue History
2018-02-13 19:07LuchsNew Issue
2018-02-17 11:59occNote Added: 0006140
2018-02-17 11:59occNote Added: 0006141
2018-02-17 12:03LuchsStatusnew => feedback
2018-02-17 12:03LuchsNote Added: 0006143
2018-02-18 21:40occNote Added: 0006147
2018-02-18 21:40occNote Added: 0006148
2019-01-27 21:37LuchsNote Added: 0006202
2019-01-27 21:37LuchsStatusfeedback => new
2019-01-27 21:37LuchsAssigned To => Luchs
2019-01-27 21:37LuchsStatusnew => resolved
2019-01-27 21:37LuchsResolutionopen => fixed
2019-01-27 21:37LuchsFixed in Version => 8.1