OpenClonk Bugtracker - OpenClonk
View Issue Details
0001943OpenClonkScenariospublic2017-09-21 23:102017-12-26 21:30
ReporterK-Pone 
Assigned ToLuchs 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version 
Target Version8.0Fixed in Version8.0 
Summary0001943: Boomshire: Goal not implemented correctly
DescriptionIn Boomshire you'll spawn on a random checkpoint, followed by a massive amount of ERROR spam in the console (when debug mode is active)
TagsNo tags attached.
Attached Files

Notes
(0005780)
Caesar   
2017-09-24 01:30   
Uh, what are the conditions for triggering this? (I just opened the editor and moved my clonk to the first checkpoint and then into lava. It didn't happen.)
(0005781)
K-Pone   
2017-09-24 14:50   
Just started the game. NativeException joined the game, and it happend right at the beginning. I spawned at checkpoint 10, which is not where you start normally. Also had a respawn delay of 10 seconds which should also not happen.

(0005802)
Clonkonaut   
2017-10-25 12:47   
Cannot reproduce locally. Is it a network-only bug?

The goal itself in Boomshire is nothing special. It's the regular Parkour goal.
(0005814)
K-Pone   
2017-10-25 14:12   
I can still reproduce this as of afa348ab21. I can recheck this once the new snapshots are built and available.
(0005826)
Clonkonaut   
2017-10-25 23:45   
I can reproduce this with the snapshot not with my self-built engine though. This is scary.
(0005884)
Caesar   
2017-10-28 04:02   
I can reproduce this with my self-built engine. But I need two players.
(0005885)
Caesar   
2017-10-28 04:24   
https://git.openclonk.org/openclonk.git/blob/HEAD:/planet/Objects.ocd/Goals.ocd/Parkour.ocd/Script.c#l468 seems to set the wrong priority on an internal effect, which causes all those beautiful errors. But if you fix that, the problem of spawning in the wrong position remains.
(0005889)
Clonkonaut   
2017-11-01 00:40   
Why is the priority causing these effects?
(0005890)
Caesar   
2017-11-02 12:43   
I don't know, I don't understand effects. I just set the priority to 1 and that does it. Wasn't there something that effects with priority != 1 have some weird replacement/stacking semantics?

Also, I debugged around a bit further and saw that the position gets set correctly in Objects.ocd/Goals.ocd/Parkour.ocd/Script.c:468 (JoinPlayer). So it gets messed up somewhere else after that. Good luck. (I have no idea how to debug something like this. Maybe stack-dump all calls to SetPosition from the Engine. Brrr.)
(0005896)
Maikel   
2017-11-10 16:17   
I can't reproduce this unfortunately.

Maybe you can overload SetPosition in C4Sript to see if something remarkable happens there:

global func SetPosition(...)
{
  Log("%d", FrameCounter());
  LogCallStack();
  return _inherited(...);
}

Framecounter I typically use to see if stuff happens in the same frame.
(0005967)
occ   
2017-12-26 13:16   
Hi! There's been a check-in that references this bug. For more information you can visit the repository browser at this address:
https://git.openclonk.org/openclonk.git/commitdiff/2ab1408e413d26aea13c40660c56a1104f87a3b2

Changeset 2ab1408 by Lukas Werling <lukas.werling@gmail.com>
Fix Boomshire spawn position (0001943)

(0005975)
Caesar   
2017-12-26 21:30   
For future reference:
22:28:14 < Luchs> The Relaunch rule has its own spawn position handling that kicks in if the rule is created.
22:28:33 < Luchs> I didn't investigate why this only happens in network rounds...
22:29:48 < Luchs> In any case, the Parkour goal also creates a restart entry in the rule menu, so that call isn't necessary in any case.


Issue History
2017-09-21 23:10K-PoneNew Issue
2017-09-24 01:30CaesarNote Added: 0005780
2017-09-24 14:50K-PoneNote Added: 0005781
2017-09-24 14:50K-PoneNote Edited: 0005781bug_revision_view_page.php?bugnote_id=5781#r1334
2017-10-25 12:47ClonkonautStatusnew => feedback
2017-10-25 12:47ClonkonautNote Added: 0005802
2017-10-25 14:12K-PoneNote Added: 0005814
2017-10-25 14:12K-PoneStatusfeedback => new
2017-10-25 23:45ClonkonautStatusnew => confirmed
2017-10-25 23:45ClonkonautNote Added: 0005826
2017-10-28 04:02CaesarNote Added: 0005884
2017-10-28 04:24CaesarNote Added: 0005885
2017-11-01 00:40ClonkonautNote Added: 0005889
2017-11-02 12:43CaesarNote Added: 0005890
2017-11-10 16:17MaikelNote Added: 0005896
2017-12-24 10:31LuchsAssigned To => Luchs
2017-12-24 10:31LuchsStatusconfirmed => assigned
2017-12-26 13:16occNote Added: 0005967
2017-12-26 13:16LuchsStatusassigned => resolved
2017-12-26 13:16LuchsResolutionopen => fixed
2017-12-26 13:16LuchsFixed in Version => 8.0
2017-12-26 21:30CaesarNote Added: 0005975
2017-12-26 21:30CaesarNote Edited: 0005975bug_revision_view_page.php?bugnote_id=5975#r1348