OpenClonk Bugtracker - OpenClonk
View Issue Details
0001928OpenClonkEnginepublic2017-06-30 08:192017-08-14 13:08
Reporterpkern 
Assigned To 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version 
Target Version8.0Fixed in Version8.0 
Summary0001928: Apply patch for reproducible builds
DescriptionIn https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=823797 I received a patch from Alexis Bienvenüe <pado@passoire.fr> (as attached) to fix the build system to produce a reproducible (bit identical) build on Debian. This requires looking at SOURCE_DATE_EPOCH if set in the environment instead of date to get the current year at build (which is displayed in a copyright notice). I'd be nice if this could be included in the next release of OpenClonk.
TagsNo tags attached.
Attached Filesdiff openclonk_7.0-3_reproductible.diff (2,176) 2017-06-30 08:19
https://bugs.openclonk.org/file_download.php?file_id=683&type=bug

Notes
(0005722)
Caesar   
2017-08-13 09:45   
We're now using STRING(TIMESTAMP C4COPYRIGHT_YEAR "%Y") (see https://git.openclonk.org/openclonk.git/commitdiff/8fef67378d193e7d116c61b4b359a8788388d6fa ) and I was wondering if this patch is still necessary.
(0005723)
Luchs   
2017-08-13 10:38   
cmake >= 3.8 seems to honor SOURCE_DATE_EPOCH [1], so it's probably fine as-is.

[1]: https://cmake.org/cmake/help/latest/command/string.html#timestamp

Issue History
2017-06-30 08:19pkernNew Issue
2017-06-30 08:19pkernFile Added: openclonk_7.0-3_reproductible.diff
2017-08-05 13:58MaikelTarget Version => 8.0
2017-08-13 09:44CaesarNote Added: 0005721
2017-08-13 09:45CaesarNote Deleted: 0005721
2017-08-13 09:45CaesarAssigned To => Caesar
2017-08-13 09:45CaesarStatusnew => feedback
2017-08-13 09:45CaesarNote Added: 0005722
2017-08-13 10:38LuchsNote Added: 0005723
2017-08-14 13:08CaesarAssigned ToCaesar =>
2017-08-14 13:08CaesarStatusfeedback => resolved
2017-08-14 13:08CaesarResolutionopen => fixed
2017-08-14 13:08CaesarFixed in Version => 8.0