OpenClonk Bugtracker - OpenClonk
View Issue Details
0001908OpenClonkEngine - C4Scriptpublic2017-04-21 17:042017-04-29 12:46
ReporterMaikel 
Assigned ToIsilkor 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Versiongit master 
Target Versiongit masterFixed in Version 
Summary0001908: Trans_Rotate(1) crashes
DescriptionJust enter this into the editor mode command line and observe.
TagsNo tags attached.
Attached Files

Notes
(0005664)
Clonkonaut   
2017-04-25 08:58   
The function crashes in any case when you omit (or zero) all three dimension parameters.

E.g. Trans_Rotate(90, 0,0,0)
(0005667)
Armin   
2017-04-27 12:30   
Should be enough: https://github.com/OCMilestoneProject/openclonk/commit/74f02f31ac9e9ec451632ce5364ee14665ba2a09
(0005668)
Zapper   
2017-04-27 13:17   
(Last edited: 2017-04-27 13:20)
@Armin I think Trans_Rotate returning a boolean is a defect. Ideally, it should warn/error and return something that still works (as in: does not throw another error) when chaining it in e.g. Trans_Mult.

PS: Why does that even compile without warnings?

(0005669)
occ   
2017-04-29 12:45   
Hi! There's been a check-in that references this bug. For more information you can visit the repository browser at this address:
https://git.openclonk.org/openclonk.git/commitdiff/33a0b4117955a4828bbe2c1cd70c069ecad2708f

Changeset 33a0b41 by Nicolas Hake <isilkor@openclonk.org>
Trans_Rotate: disallow rotation around null vector (0001908)

Trans_Rotate will now raise at runtime if the user tries to generate a
rotation matrix around a null vector instead of crashing with #DE.


Issue History
2017-04-21 17:04MaikelNew Issue
2017-04-25 08:58ClonkonautStatusnew => acknowledged
2017-04-25 08:58ClonkonautNote Added: 0005664
2017-04-27 12:30ArminNote Added: 0005667
2017-04-27 13:17ZapperNote Added: 0005668
2017-04-27 13:20ZapperNote Edited: 0005668bug_revision_view_page.php?bugnote_id=5668#r1322
2017-04-29 12:45occNote Added: 0005669
2017-04-29 12:46IsilkorAssigned To => Isilkor
2017-04-29 12:46IsilkorStatusacknowledged => resolved
2017-04-29 12:46IsilkorResolutionopen => fixed