OpenClonk Bugtracker - OpenClonk
View Issue Details
0001691OpenClonkObjectspublic2016-02-27 13:222018-01-22 18:17
Reporterpluto 
Assigned ToZapper 
PriorityhighSeverityminorReproducibilitysometimes
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version 
Target Version8.0Fixed in Version 
Summary0001691: Bow, (and musket) after shot (or recharge) keep in the kind of aiming mode, without mouse pressed that prevents climbing
DescriptionSometimes when shooting arrows with the bow, the clonk stays in the aiming mode (that you usually have when mousebutton is hold) without holding left mouse button. That causes that you end up being slowed down, prevents you from climbing and causes you to fall down tumbeling.
Similar thing applies to the musket when it is shot and reloaded. With musket it is not predictable as there is no aiming mode(?) however you also cannot climb eighter.
You can end this funny problem by switching to another item (and back) or by rightclick (which surprisingly does not end with the item thrown away). That brings you back to normal.

I had the impression it can also happen with the javelin, but that is not sure.
Steps To ReproduceBest do reproduce is the race scenario of Mimmo, where the aim is to shoot 16? or so targets in a small labyrinth like map. It is very sure that you end up with that bug at some point (until now it allway happend to everybody in that particular round) and it is easy to notice, because the map involves a lot of climbing directly after shooting a target.

However I noticed that problem also in Brunnen(not sure because you usually die quite quickly) and definitly in Hei├čes Eis.
TagsNo tags attached.
related to 0001787resolved Zapper Grenade Launcher: Does not always show aim preview 
Attached Files

Notes
(0005007)
Zapper   
2016-02-27 14:45   
Sound like ControlUseStart would be called, putting the Clonk into "aiming mode" and then ControlUseStop would never be called.

It's possible that the Stop callbac is just missing at some point(?)
(0005010)
Clonkonaut   
2016-02-28 14:02   
It get this behaviour whenever I press in the direction of a wall, i.e. my clonk would scale (but scaling is deactivated in a bad way). Very annoying, makes bow handling very bad right now. :/
(0005011)
Clonkonaut   
2016-02-28 14:04   

Reminder sent to: Sven2

So, I guess this has something to do with 729712fa2fe8fd420e07e4f915a68ab541e19850.
(0005012)
Sven2   
2016-02-28 14:15   
(Last edited: 2016-02-28 14:16)
Scaling is deactivated while you aim a weapon because the alternative (Clonk stops aiming) was very bad for melees. You would randomly stop aiming all the time.

I noticed that there seem to be some bugs with clonks staying in aim mode.

(0006021)
Caesar   
2018-01-08 22:08   
One way of reproducing this: start Hot Ice in explosive mode, shoot into the air, start reloading, switch to the wind bag, get hit by your own grenade.
(0006024)
Caesar   
2018-01-09 11:40   
Argh. So the reason for this probably lies in the shelved command logic/magic, which reissues the ControlUseStart, but no ControlUseStop. Or so.
(0006027)
K-Pone   
2018-01-09 20:36   
Proper way to reproduce: Reload any reloadable weapon (i.e. Grenade Launcher or Musket), get hit by something (like a projectile or any flung objects like ice in Hot Ice) while you're still reloading. Don't switch items now but rather wait until you reloaded: You're aiming now even without having the mouse button pressed.

Btw, switching items while you're tumbling after you started reloading can actually cause "Aim Lock" (Grneade lanucher holding in hand like you're aiming, but unable to aim or shoot, along with no aim preview)
(0006032)
Marky   
2018-01-11 19:05   
This also happens in the fight tutorial, if you aim the javelin at the archer and he hits you with an arrow.
(0006052)
occ   
2018-01-13 15:05   
Hi! There's been a check-in that references this bug. For more information you can visit the repository browser at this address:
https://git.openclonk.org/openclonk.git/commitdiff/825ad64afddd97fb637d18595204abf1fdc6914f

Changeset 825ad64 by David Dormagen <czapper@gmx.de>
AimManager: fixed incorrect use of PauseUse leading to aiming without holding CON_Use (0001691)

PauseUse can be called between ControlUseStart and ControlUseStop/Cancel. In this case ControlUseStop set aim_stop=1 but didn't actually stop reloading (which is somewhat fine). However, this led to PauseUse being called when e.g. tumbling or climbing.
And this again would lead to CON_Use being reissued even though the mouse button was not held down, leading to the Clonk being in aim mode.

The functional change here is that you will not continue reloading after tumbling/climbing when you are not holding down CON_Use anymore, which is consistent with other stuff.

(0006053)
Zapper   
2018-01-13 15:07   
I fixed the problem where you would be in aim mode when:
    1. you start reloading
    2. you let go of the mouse button
    3. you start climbing / tumbling

I am not quite sure whether this covers all situations of this issue.
Please test and tell if it still happens!
(0006068)
Caesar   
2018-01-15 10:45   
I couldn't reproduce the aimlock behaviour anymore, yesterday. However, someone (@Sven2 I think) deliberately disabled climbing while reloading, because otherwise you'd break off the process too often while running around in a bumpy landscape. That has reverted back, and I'm not sure I like it.

A little bit of oddity still remains when picking up a boompack while reloading, but that is temporary.
(0006070)
Sven2   
2018-01-16 02:28   
I just checked it: Climbing is disabled if you hold down the mouse button to load/aim. If you just click once to start loading, then climbing will interrupt the loading procedure.

I think that's fine.

Issue History
2016-02-27 13:22plutoNew Issue
2016-02-27 14:45ZapperNote Added: 0005007
2016-02-28 14:02ClonkonautNote Added: 0005010
2016-02-28 14:04ClonkonautNote Added: 0005011
2016-02-28 14:15Sven2Note Added: 0005012
2016-02-28 14:16Sven2Note Edited: 0005012bug_revision_view_page.php?bugnote_id=5012#r1221
2017-08-05 13:58MaikelTarget Version => 8.0
2018-01-08 22:08CaesarNote Added: 0006021
2018-01-09 11:40CaesarNote Added: 0006024
2018-01-09 15:23CaesarRelationship addedrelated to 0001787
2018-01-09 20:36K-PoneNote Added: 0006027
2018-01-11 19:05MarkyNote Added: 0006032
2018-01-13 15:05occNote Added: 0006052
2018-01-13 15:07ZapperNote Added: 0006053
2018-01-13 15:07ZapperAssigned To => Zapper
2018-01-13 15:07ZapperStatusnew => feedback
2018-01-15 10:45CaesarNote Added: 0006068
2018-01-16 02:28Sven2Note Added: 0006070
2018-01-22 18:17CaesarStatusfeedback => resolved
2018-01-22 18:17CaesarResolutionopen => fixed