OpenClonk Bugtracker - OpenClonk
View Issue Details
0001642OpenClonkWebsite - Automated Buildspublic2016-01-19 16:332017-10-26 13:02
ReporterLuchs 
Assigned To 
PrioritynormalSeverityminorReproducibilityalways
StatusnewResolutionopen 
PlatformOSOS Version
Product Version 
Target Versiongit masterFixed in Version 
Summary0001642: In the release source tarball, all files are marked as executable
DescriptionOnly files that are actually executable should be marked as executable.
Steps To Reproducewget http://www.openclonk.org/builds/release/7.0/openclonk-7.0-src.tar.bz2
tar tvf openclonk-7.0-src.tar.bz2
Additional Informationhttp://www.openclonk.org/builds/release/7.0/openclonk-7.0-src.tar.bz2
TagsNo tags attached.
Attached Files

Notes
(0004827)
Isilkor   
2016-01-19 21:08   
Not my bug, the exported source tree (https://git.openclonk.org/openclonk.git/archive/openclonk-release-7.0-src.tar.bz2) is correct; somebody broke things when uploading to www.openclonk.org
(0004858)
Isilkor   
2016-01-23 19:43   

Reminder sent to: Newton

Newton may have uploaded the tarball to openclonk.org.
(0004862)
Newton   
2016-01-24 10:56   
Apparently Windows does add it when I touch the contents of the tar.

I do unpack and pack it again because I remove the Experimental.ocf, Tests.ocf etc. folders as I do not want them to turn up in
* Linux packages of the game (.deb, .rpm,...)
* the folder in which a (Linux) user decides to compile the game himself

That I do this manually is a temporary solution anyway. Couldn't the build system be extended to do this automatically? When is the source package on git archive created - is it already available when the release button is pushed?
(0004863)
Isilkor   
2016-01-24 10:57   
> When is the source package on git archive created - is it already available when the release button is pushed?
It's created whenever somebody pushes a tag to the repository.
(0004864)
Newton   
2016-01-24 11:15   
...Which happens after the button has been pushed. So the release scripts have to create a source tar themself.
(0004865)
Isilkor   
2016-01-24 11:22   
> Which happens after the button has been pushed.
Well if somebody releases before pushing a tag that's their own fault.
(0004867)
Newton   
2016-01-24 12:02   
That is beside the point, it is enough that it is possible and valid to do so (as it is described like this in the wiki) that makes it necessary that the release scripts have to create a source tar themselves.
(0004868)
Isilkor   
2016-01-24 12:14   
Ignoring the wiki, since you won't find anything there because there's no search function, let me quote the release tool for you:

Pre Release Checklist

Dont forget to increase the version number in Version.txt.
Run a Dry Release to make sure the generated files are correct. Dry Release Area
Create a tag for the release.

Emphasis mine.

(0004869)
Newton   
2016-01-24 13:36   
(Last edited: 2016-01-24 13:37)
My previous point holds. Anyway, the wiki article is here:
http://wiki.openclonk.org/w/Release_Steps

I corrected it.

(0004870)
Maikel   
2016-01-24 13:48   
In the 6.0 series we explicitly decided to tag after the release has been done, in case something goes wrong. So now we change that?
(0004871)
Isilkor   
2016-01-24 13:53   
"In case something goes wrong" doesn't really apply because we can do dry releases, which do the exact same thing as the real deal except updating the website.

Issue History
2016-01-19 16:33LuchsNew Issue
2016-01-19 16:33LuchsStatusnew => assigned
2016-01-19 16:33LuchsAssigned To => Isilkor
2016-01-19 21:08IsilkorNote Added: 0004827
2016-01-19 21:08IsilkorAssigned ToIsilkor =>
2016-01-19 21:08IsilkorStatusassigned => new
2016-01-23 19:43IsilkorNote Added: 0004858
2016-01-24 10:56NewtonNote Added: 0004862
2016-01-24 10:57IsilkorNote Added: 0004863
2016-01-24 11:15NewtonNote Added: 0004864
2016-01-24 11:22IsilkorNote Added: 0004865
2016-01-24 12:02NewtonNote Added: 0004867
2016-01-24 12:14IsilkorNote Added: 0004868
2016-01-24 12:14IsilkorNote Edited: 0004868bug_revision_view_page.php?bugnote_id=4868#r1181
2016-01-24 13:36NewtonNote Added: 0004869
2016-01-24 13:37NewtonNote Edited: 0004869bug_revision_view_page.php?bugnote_id=4869#r1183
2016-01-24 13:48MaikelNote Added: 0004870
2016-01-24 13:53IsilkorNote Added: 0004871
2017-08-05 13:58MaikelTarget Version => 8.0
2017-10-26 13:02ClonkonautTarget Version8.0 => git master