OpenClonk Bugtracker - OpenClonk
View Issue Details
0001429OpenClonkEngine - Graphicspublic2015-10-18 21:172017-12-23 11:35
ReporterClonk-Karl 
Assigned To 
PrioritynormalSeverityminorReproducibilityalways
StatusacknowledgedResolutionopen 
PlatformLinuxOSGentoo LinuxOS Version~amd64
Product Version 
Target Versiongit masterFixed in Version 
Summary0001429: Landscape edges have shadows
DescriptionThis comes from landscape edges being marked as material borders. They shouldn't at least when the sides are not open. See screenshot.
Steps To ReproduceStart Tests.ocf/Minimal.ocs, walk to the left or right edge of the landscape.
TagsNo tags attached.
Attached Filespng shadow_at_border.png (123,329) 2015-10-18 21:17
https://bugs.openclonk.org/file_download.php?file_id=516&type=bug
png

Notes
(0003969)
Sven2   
2015-10-18 22:16   
I don't think this is a problem. The border is "magical" anyway, why shouldn't it drop a shadow?
(0003971)
Clonk-Karl   
2015-10-18 23:01   
To me it looks unnatural somehow. Like there's a 90 degree cliff right where the landscape ends. Maybe the clonk world is a disk :P

By the way, on the other side of the map the edge is actually brighter, not darker than the rest of the material. Like there's an extra light source somewhere on that side of the landscape.
(0003972)
Sven2   
2015-10-18 23:03   
(Last edited: 2015-10-18 23:04)
Well, but is there a way to solve it without having a ton of coordinate border checks in the shader code? Like a texture addressing mode that mirrors the borders (but would that work with non-POT?)

(0003973)
Clonk-Karl   
2015-10-18 23:28   
The material edges are computed in CPU. And it makes sense that way, because if they were in the shader, they would need lots of texture fetches for each fragment.

I'd expect a fix for this to be fairly simple actually.
(0004169)
Clonkonaut   
2015-11-30 11:16   
Changed Target Version to 8.0

This isn't release blocking and even if the fix is easy, no one's done it yet! But can be done anytime.

Issue History
2015-10-18 21:17Clonk-KarlNew Issue
2015-10-18 21:17Clonk-KarlTarget Version => 7.0
2015-10-18 21:17Clonk-KarlFile Added: shadow_at_border.png
2015-10-18 22:16Sven2Note Added: 0003969
2015-10-18 23:01Clonk-KarlNote Added: 0003971
2015-10-18 23:03Sven2Note Added: 0003972
2015-10-18 23:04Sven2Note Edited: 0003972bug_revision_view_page.php?bugnote_id=3972#r968
2015-10-18 23:28Clonk-KarlNote Added: 0003973
2015-11-30 11:16ClonkonautStatusnew => acknowledged
2015-11-30 11:16ClonkonautTarget Version7.0 => 8.0
2015-11-30 11:16ClonkonautNote Added: 0004169
2017-12-23 11:35LuchsTarget Version8.0 => git master