Anonymous Login
2017-05-25 16:22 CEST

View Issue Details Jump to Notes ]
IDProjectCategoryView StatusLast Update
0001908OpenClonkEngine - C4Scriptpublic2017-04-29 14:46
ReporterMaikel 
Assigned ToIsilkor 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
Product Versiongit master 
Target Versiongit masterFixed in Version 
Summary0001908: Trans_Rotate(1) crashes
DescriptionJust enter this into the editor mode command line and observe.
TagsNo tags attached.
Attached Files

-Relationships
+Relationships

-Notes

~0005664

Clonkonaut (developer)

The function crashes in any case when you omit (or zero) all three dimension parameters.

E.g. Trans_Rotate(90, 0,0,0)

~0005667

Armin (reporter)

Should be enough: https://github.com/OCMilestoneProject/openclonk/commit/74f02f31ac9e9ec451632ce5364ee14665ba2a09

~0005668

Zapper (developer)

Last edited: 2017-04-27 15:20

View 2 revisions

@Armin I think Trans_Rotate returning a boolean is a defect. Ideally, it should warn/error and return something that still works (as in: does not throw another error) when chaining it in e.g. Trans_Mult.

PS: Why does that even compile without warnings?

~0005669

occ (reporter)

Hi! There's been a check-in that references this bug. For more information you can visit the repository browser at this address:
https://git.openclonk.org/openclonk.git/commitdiff/33a0b4117955a4828bbe2c1cd70c069ecad2708f

Changeset 33a0b41 by Nicolas Hake <isilkor@openclonk.org>
Trans_Rotate: disallow rotation around null vector (0001908)

Trans_Rotate will now raise at runtime if the user tries to generate a
rotation matrix around a null vector instead of crashing with #DE.

+Notes

-Issue History
Date Modified Username Field Change
2017-04-21 19:04 Maikel New Issue
2017-04-25 10:58 Clonkonaut Status new => acknowledged
2017-04-25 10:58 Clonkonaut Note Added: 0005664
2017-04-27 14:30 Armin Note Added: 0005667
2017-04-27 15:17 Zapper Note Added: 0005668
2017-04-27 15:20 Zapper Note Edited: 0005668 View Revisions
2017-04-29 14:45 occ Note Added: 0005669
2017-04-29 14:46 Isilkor Assigned To => Isilkor
2017-04-29 14:46 Isilkor Status acknowledged => resolved
2017-04-29 14:46 Isilkor Resolution open => fixed
+Issue History